Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: fix build-and-push-with-qemu on v1.11 #18071

Merged
merged 1 commit into from Dec 2, 2021
Merged

workflows: fix build-and-push-with-qemu on v1.11 #18071

merged 1 commit into from Dec 2, 2021

Conversation

nbusseneau
Copy link
Member

We removed the PR bits in build-and-push-with-qemu in 5ae34dd, which means the job should use ${{ github.sha }} directly.

Fixes: 8bbae9c

@nbusseneau
workflows: fix build-and-push-with-qemu on v1.11
93291f1 
We removed the PR bits in `build-and-push-with-qemu` in
5ae34dd, which means the job should use
`${{ github.sha }}` directly.

Fixes: 8bbae9c

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Nov 30, 2021
@nbusseneau nbusseneau requested a review from aanm November 30, 2021 18:06
@nbusseneau nbusseneau requested review from a team as code owners November 30, 2021 18:06
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Nov 30, 2021
aanm
aanm requested changes Nov 30, 2021
View reviewed changes
Copy link
Member

@aanm aanm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we add something similar as lines 62-69?

@nbusseneau
Copy link
Member Author

Why don't we add something similar as lines 62-69

The QEMU job only runs on push events, hence it is useless to have an intermediate step checking if we are on a pull_request or not and then retrieving either the SHA from the PR or the SHA from the GitHub context, thus we use the GitHub context SHA immediately.

@joestringer joestringer merged commit f185a6d into cilium:v1.11 Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm requested changes

@joestringer joestringer joestringer approved these changes

@nebril nebril nebril approved these changes

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nbusseneau @joestringer @nebril @pchaigno @aanm