Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubectl CI flakiness #18087

Merged
merged 2 commits into from Dec 2, 2021
Merged

Fix kubectl CI flakiness #18087

merged 2 commits into from Dec 2, 2021

Conversation

aanm
Copy link
Member

@aanm aanm commented Dec 1, 2021

Fixes #18060

@aanm
Revert "test/helpers: fix ensure kubectl version to work for RCs"
b7edc5a 
This reverts commit bb6ef27.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added area/CI Continuous Integration testing issue or flake needs-backport/1.11 labels Dec 1, 2021
@aanm aanm requested a review from a team as a code owner December 1, 2021 22:29
@aanm aanm requested a review from nbusseneau December 1, 2021 22:29
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.0 Dec 1, 2021
@aanm aanm added the release-note/ci This PR makes changes to the CI. label Dec 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 1, 2021
@aanm
Copy link
Member Author

aanm commented Dec 1, 2021 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.16-net-next' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sDemosTest Tests Star Wars Demo

Failure Output

FAIL: failed to ensure the namespace kube-system exists: exit status 2

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.16-net-next so I can create a new GitHub issue to track it.

@aanm
Copy link
Member Author

aanm commented Dec 1, 2021

/test

joestringer
joestringer reviewed Dec 1, 2021
View reviewed changes
test/helpers/kubectl.go Outdated Show resolved Hide resolved
@aanm
test/helpers: use rc.0 as the default version of kubectl
2892ef7 
Since we only update the Kubernetes version tested on our CI when the
first RC is announced we should use that binary instead of the `.0` as
the `.0` is not available at the time the rc.0 is released.

Fixes: 6181255 ("test: ensure kubectl version is available for test run")
Signed-off-by: André Martins <andre@cilium.io>
@joestringer
Copy link
Member

joestringer commented Dec 2, 2021 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.22-kernel-4.19' hit: #18072 (86.94% similarity)

Job 'Cilium-PR-K8s-1.23-kernel-4.9' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sIstioTest Istio Bookinfo Demo Tests bookinfo inter-service connectivity

Failure Output

FAIL: Found 1 io.cilium/app=operator logs matching list of errors that must be investigated:

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.23-kernel-4.9 so I can create a new GitHub issue to track it.

Job 'Cilium-PR-K8s-GKE' hit: #17270 (94.73% similarity)

This was referenced Dec 2, 2021
Closed
Closed
@aanm
Copy link
Member Author

aanm commented Dec 2, 2021 •
edited by maintainer-s-little-helper bot

/mlh new-flake Cilium-PR-K8s-1.23-kernel-4.9

👍 created #18094

@aanm aanm merged commit 75fbebb into cilium:master Dec 2, 2021
@aanm aanm deleted the pr/fix-kubectl branch December 2, 2021 11:24
@qmonnet qmonnet mentioned this pull request Dec 2, 2021
Merged
18 tasks
@nathanjsweet nathanjsweet mentioned this pull request Dec 2, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.0 Dec 2, 2021
@joestringer joestringer added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Dec 3, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.0 Dec 3, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.0 Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@christarazi christarazi christarazi approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.11.0
Backport done to v1.11
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: failed to ensure kubectl version: failed to download kubectl
5 participants
@aanm @joestringer @christarazi @nbusseneau @nathanjsweet