helm: Fix operator cloud image digests #18116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
release-blocker/1.11
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
Tested by applying this patch to v1.11 branch and validating that the
digest matches the correct cloud image vs. the v1.11.0-rc3 images on
Quay.io:
$ helm template cilium ./install/kubernetes/cilium/ --version 1.10.0-rc3 \
--namespace kube-system --set eni.enabled=true --set ipam.mode=eni \
--set egressMasqueradeInterfaces=eth0 --set tunnel=disabled \
| grep operator.*sha
image: quay.io/cilium/operator-aws:v1.11.0-rc3@sha256:5ea0ccb6a866a5fb13f4bdfcf1ed8bce12a1355cb10a0914ea52af25f3a8f931
Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
submit/fix-cloud-operator-helm-charts
branch
from
a3ed39f
to
5cc4f75
Compare
|
Note, these helm changes are not tested in CI and not in the master CI, so the best we can do is to review & merge it. No point in triggering the full testsuite. |
joestringer
removed
the
release-note/misc
nathanjsweet
approved these changes
Dec 3, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.11.0
joestringer
added
backport-done/1.11
joestringer
moved this from Backport pending to v1.11
to Backport done to v1.11
in 1.11.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by applying this patch to v1.11 branch and validating that the
digest matches the correct cloud image vs. the v1.11.0-rc3 images on
Quay.io:
Fixes: 4638de2 ("cleanup the cilium helm chart:")
Fixes: 1ccb845 ("install/kubernetes: fix helm generation for operator image digest")