Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identity: fix incorrect maximum identity when ClusterID > 0 #18148

Merged
merged 1 commit into from
Dec 8, 2021
Merged

identity: fix incorrect maximum identity when ClusterID > 0 #18148

merged 1 commit into from
Dec 8, 2021

Conversation

ArthurChiao
Copy link
Contributor

Calculate MaximumAllocationIdentity during module initialization is not
enough as user specified 'ClusterID' hasn't been parsed during this phase.

This patch fixed the problem by recalculating the max identity during
runtime initialization when ClusterID > 0.

Signed-off-by: ArthurChiao arthurchiao@hotmail.com

@ArthurChiao
identity: fix incorrect maximum identity when ClusterID > 0
ec911b1 
Calculate MaximumAllocationIdentity during module initialization is not
enough as user specified 'ClusterID' hasn't been parsed during this phase.

This patch fixed the problem by recalculating the max identity during
runtime initialization when `ClusterID > 0`.

Signed-off-by: ArthurChiao <arthurchiao@hotmail.com>
@ArthurChiao ArthurChiao requested review from a team and twpayne December 7, 2021 02:34
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 7, 2021
@twpayne
Copy link
Contributor

twpayne commented Dec 7, 2021

/test

@twpayne twpayne added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Dec 7, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 7, 2021
@borkmann
Copy link
Member

borkmann commented Dec 8, 2021

@twpayne this needs backporting as well, e.g. 1.11?

@twpayne twpayne added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. needs-backport/1.11 and removed backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. labels Dec 8, 2021
@nbusseneau
Copy link
Member

Thanks @ArthurChiao! Merging.

@nbusseneau nbusseneau merged commit 4b16aee into cilium:master Dec 8, 2021
@ArthurChiao ArthurChiao deleted the fix_wrong_max_identity branch December 9, 2021 01:17
@nbusseneau nbusseneau mentioned this pull request Dec 10, 2021
Merged
@tklauser tklauser added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Dec 16, 2021
@pchaigno pchaigno mentioned this pull request Jan 11, 2022
Closed
2 tasks
@aanm aanm added the kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. label Jan 12, 2022
@joestringer joestringer mentioned this pull request Jan 18, 2022
Merged
@joestringer joestringer added release-note/bug This PR fixes an issue in a previous release of Cilium. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twpayne twpayne twpayne approved these changes

Assignees
No one assigned
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ArthurChiao @twpayne @borkmann @nbusseneau @tklauser @joestringer @aanm