Makefile: Push image in 'kind-image' target #18167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the developer set the imagePullPolicy to Always, then kind would always end up pulling the image version from the localhost:5000 registry instead of using the version we sideload in the final step here. Avoid this by unconditionally pushing the image to the local registry. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
needs-backport/1.11
release-note/misc
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
gandro
approved these changes
Dec 8, 2021
glibsm
approved these changes
Dec 8, 2021
joestringer
added
the
ready-to-merge
tklauser
added
backport-done/1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the developer set the
imagePullPolicytoAlways, then kind wouldalways end up pulling the image version from the
localhost:5000registryinstead of using the version we sideload in the final step here. Avoid
this by unconditionally pushing the image to the local registry.