Revert "test/Services: Quarantine 'Checks service on same node'" #18170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ca4ed8d ("test/Services: Quarantine 'Checks service on same node'"). The original intention was to quarantine the test from #17919. However, ca4ed8d quarantined the /wrong/ test case which was not the failing one since the code in mentioned commit only covers the IPv6 one and in the test the IPv4 one was failing. Meanwhile, the IPv4 test for 'Checks service on same node' was still left active on master, and looking at CI dashboard from last few days on master there has been no failure related to any of the 'Checks service on same node' tests. Closes: #17919 Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
borkmann
added
area/CI
|
/test Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment |
brb
approved these changes
Dec 8, 2021
joestringer
approved these changes
Dec 8, 2021
tklauser
added
backport-done/1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ca4ed8d ("test/Services: Quarantine 'Checks service on
same node'"). The original intention was to quarantine the test from #17919.
However, ca4ed8d quarantined the /wrong/ test case which was not the failing
one since the code in mentioned commit only covers the IPv6 one and in the test
the IPv4 one was failing. Meanwhile, the IPv4 test for 'Checks service on same
node' was still left active on master, and looking at CI dashboard from last few
days on master there has been no failure related to any of the 'Checks service on
same node' tests.