Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use stable zookeeper image #18186

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Dec 8, 2021

Commit f665152 ("test: Use stable tags instead of :latest")
switched most use of image tags to stable tags, but omitted one
occurrence of the zookeeper image in the runtime kafka tests. Switch it
to the stable docker.io/cilium/zookeeper:1.0 as well.

Fixes: f665152 ("test: Use stable tags instead of :latest")

@tklauser tklauser added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. needs-backport/1.10 labels Dec 8, 2021
@tklauser tklauser requested a review from a team as a code owner December 8, 2021 22:16
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.6 Dec 8, 2021
Commit f665152 ("test: Use stable tags instead of :latest")
switched most use of image tags to stable tags, but omitted one
occurrence of the zookeeper image in the runtime kafka tests. Switch it
to the stable docker.io/cilium/zookeeper:1.0 as well.

Fixes: f665152 ("test: Use stable tags instead of :latest")
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser
Copy link
Member Author

tklauser commented Dec 8, 2021

/test-runtime

@tklauser
Copy link
Member Author

tklauser commented Dec 9, 2021

The necessary review is in and runtime tests passed. The change doesn't affect other tests, so no need to run full CI. Marking as ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 9, 2021
@nbusseneau nbusseneau merged commit 1305bab into cilium:master Dec 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.6 Dec 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.6 Dec 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.6 Dec 10, 2021
@tklauser tklauser added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Dec 16, 2021
@tklauser tklauser deleted the pr/zookeeper-image branch January 5, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.6
Backport done to v1.10
Development

Successfully merging this pull request may close these issues.

None yet

3 participants