Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Fix hubble-ui image references #18209

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

joestringer
Copy link
Member

The variable was not enclosed fully in speechmarks, observed by seeing
failures in make -C install/kubernetes while backporting this to older
branches.

The variable was not enclosed fully in speechmarks, observed by seeing
failures in `make -C install/kubernetes` while backporting this to older
branches.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer requested a review from a team as a code owner December 9, 2021 22:49
@joestringer joestringer requested review from a team and kaworu December 9, 2021 22:49
@joestringer joestringer requested a review from aanm December 9, 2021 22:49
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.12 Dec 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.6 Dec 9, 2021
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Dec 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.10.6 Dec 9, 2021
@joestringer
Copy link
Member Author

I fixed this up manually in the v1.10 backport PR #18210 . For the other branches we can merge & backport this normally.

@aanm aanm merged commit 701967f into cilium:master Dec 10, 2021
This was referenced Dec 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.12 Dec 10, 2021
@tklauser tklauser added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.9 and removed backport-pending/1.11 labels Dec 16, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.12 Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.9.12
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

None yet

6 participants