Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: Fix CRD schema version for v2alpha1 #18215

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

joestringer
Copy link
Member

Make the v2alpha1 schema definitions match the scheme version for v2, so that
the docs script which documents this will format the docs page correctly.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer requested a review from a team December 10, 2021 02:59
@joestringer joestringer added needs-backport/1.11 release-note/misc This PR makes changes that have no direct user impact. labels Dec 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 10, 2021
@aanm
Copy link
Member

aanm commented Dec 10, 2021

I assume this also needs v1.10 backport?

@joestringer
Copy link
Member Author

@aanm no, this is only a problem on master / v1.11 as they are the ones inconsistently using the versions 1.24.1/1.24.2. v1.10 uses v1.23.3 currently. The only reason we hit issues with this while preparing v1.10 is that the script itself generates the full set of schema versions for all of the 'supported branches' + master at the time that we prepared that branch. So for instance v1.10 checks v1.8, v1.9, v1.10 and master.

@joestringer joestringer merged commit 2a27c7c into cilium:master Dec 10, 2021
@joestringer joestringer deleted the submit/schema-versions branch December 10, 2021 19:19
@tklauser tklauser added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants