Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for data race in IP release features #18217

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Fix for data race in IP release features #18217

merged 1 commit into from
Dec 13, 2021

Conversation

hemanthmalla
Copy link
Member

Fixes: #18204

Signed-off-by: Hemanth Malla hemanth.malla@datadoghq.com

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 10, 2021
@hemanthmalla hemanthmalla force-pushed the hemanth.malla/ip_release_data_race branch from deb336e to 643f0e5 Compare December 10, 2021 04:08
@hemanthmalla
Fix for data race in IP release features
55e1482 
Fixes: cilium#18204

Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com>
@hemanthmalla hemanthmalla force-pushed the hemanth.malla/ip_release_data_race branch from 643f0e5 to 55e1482 Compare December 10, 2021 04:12
@christarazi
Copy link
Member

christarazi commented Dec 10, 2021 •
edited

/test-race

Edit: Looks like we hit a few data races and they are known #17914.

@christarazi
Copy link
Member

christarazi commented Dec 10, 2021 •
edited

/test

Edit:

@hemanthmalla hemanthmalla marked this pull request as ready for review December 10, 2021 14:06
@hemanthmalla hemanthmalla requested review from a team and twpayne December 10, 2021 14:06
@qmonnet qmonnet mentioned this pull request Dec 10, 2021
Merged
@joestringer joestringer added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Dec 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 10, 2021
gandro
gandro approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Note that this fixes an issue in the Travis pipeline, not the Jenkins race pipeline.

Also marking for backport as the underlying code is scheduled for a v1.11 backport too.

@gandro
Copy link
Member

gandro commented Dec 13, 2021

Marking this as ready to merge, as this is impacting the stability of our Travis pipeline and all test failures are unrelated as per Chris' investigation above.

@gandro gandro added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 13, 2021
@hemanthmalla hemanthmalla mentioned this pull request Dec 13, 2021
Merged
@nbusseneau
Copy link
Member

@hemanthmalla Thanks for the PR! Merging.

@nbusseneau nbusseneau merged commit f542724 into cilium:master Dec 13, 2021
@hemanthmalla hemanthmalla mentioned this pull request Dec 13, 2021
Merged
@tklauser tklauser added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Dec 16, 2021
@joestringer joestringer mentioned this pull request Jan 18, 2022
Merged
@jaredledvina jaredledvina mentioned this pull request Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@twpayne twpayne Awaiting requested review from twpayne

Assignees

@twpayne twpayne

Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Travis fatal error: concurrent map iteration and map write in github.com/cilium/cilium/pkg/ipam
7 participants
@hemanthmalla @christarazi @gandro @nbusseneau @twpayne @tklauser @joestringer