Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/aws/aws-sdk-go-v2 to v1.11.2 #18220

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

ese
Copy link
Contributor

@ese ese commented Dec 10, 2021

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Update AWS SDK go libraries to support latest EC2 instances types like m6a

Fixes: #18197

Update aws-sdk-go-v2 to support m6a c6i im4gn is4gen g5g g5 EC2 instances types

@ese ese requested a review from a team as a code owner December 10, 2021 09:41
@ese ese requested a review from rolinh December 10, 2021 09:41
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 10, 2021
@ese ese changed the title Update aws sdk Update github.com/aws/aws-sdk-go-v2 to v1.11.2 Fixes: #18197 Dec 10, 2021
@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Dec 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 10, 2021
@tklauser tklauser changed the title Update github.com/aws/aws-sdk-go-v2 to v1.11.2 Fixes: #18197 Update github.com/aws/aws-sdk-go-v2 to v1.11.2 Dec 10, 2021
@borkmann
Copy link
Member

/test

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ese How did you update the dependency? It looks like there is an issue with vendoring. Could you please try the following with Go 1.17.x:

$ go get github.com/aws/aws-sdk-go-v2@latest
$ go get github.com/aws/aws-sdk-go-v2/config@latest
$ go get github.com/aws/aws-sdk-go-v2/feature/ec2/imds@latest
$ go get github.com/aws/aws-sdk-go-v2/service/ec2@latest
$ go mod tidy && go mod vendor
$ git commit --amend go.mod go.sum vendor/

Signed-off-by: Sergio Ballesteros <snaker@locolandia.net>
@ese
Copy link
Contributor Author

ese commented Dec 10, 2021

Done following your path @tklauser with go version go1.17.5 linux/amd64

Thanks!

@tklauser
Copy link
Member

/ci-eks

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ese!

@tklauser
Copy link
Member

/ci-awscni

@tklauser
Copy link
Member

Tests passed on AWS-CNI and EKS, marking as ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 13, 2021
@nbusseneau nbusseneau merged commit 0a4d381 into cilium:master Dec 13, 2021
@tklauser tklauser added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Dec 17, 2021
@ese ese deleted the update-aws-sdk branch December 23, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cilium agent crashloopback running on m6a instances
5 participants