Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.11: Update Go to 1.17.5 #18225

Merged
merged 2 commits into from
Dec 13, 2021
Merged

v1.11: Update Go to 1.17.5 #18225

merged 2 commits into from
Dec 13, 2021

Conversation

tklauser
Copy link
Member

No description provided.

@tklauser
Update Go to 1.17.5
a41d607 
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added kind/backports This PR provides functionality previously merged into master. release-note/misc This PR makes changes that have no direct user impact. backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. labels Dec 10, 2021
@tklauser tklauser temporarily deployed to release-base-images December 10, 2021 13:51 Inactive
@tklauser tklauser temporarily deployed to release-base-images December 10, 2021 13:51 Inactive
@tklauser
images: update cilium-{runtime,builder}
d05cb2e 
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser marked this pull request as ready for review December 10, 2021 14:03
@tklauser tklauser requested review from a team as code owners December 10, 2021 14:03
@tklauser tklauser temporarily deployed to release-base-images December 10, 2021 14:04 Inactive
@tklauser tklauser temporarily deployed to release-base-images December 10, 2021 14:04 Inactive
michi-covalent
michi-covalent approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@tklauser
Copy link
Member Author

tklauser commented Dec 10, 2021 •
edited by maintainer-s-little-helper bot

/test-backport-1.11

Job 'Cilium-PR-Runtime-net-next' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

RuntimePrivilegedUnitTests Run Tests

Failure Output

FAIL: Failed to run privileged unit tests

If it is a flake, comment /mlh new-flake Cilium-PR-Runtime-net-next so I can create a new GitHub issue to track it.

Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sDatapathConfig DirectRouting Check connectivity with direct routing

Failure Output

FAIL: Connectivity test between nodes failed

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-GKE so I can create a new GitHub issue to track it.

@tklauser
Copy link
Member Author

tklauser commented Dec 13, 2021 •
edited

/test-runtime

rerun to check if this is related, there were Go changes to syscall.Pipe and in the failed test there seem to be some goroutines stuck in pipe read: https://jenkins.cilium.io/job/Cilium-PR-Runtime-net-next/837/

@tklauser
Copy link
Member Author

tklauser commented Dec 13, 2021 •
edited

/test-1.20-4.9

https://jenkins.cilium.io/job/Cilium-PR-K8s-1.20-kernel-4.9/1191/ failed on #18060, should be fixed once #18232 is merged.

@tklauser
Copy link
Member Author

tklauser commented Dec 13, 2021 •
edited

/test-1.21-5.4

failed on #17010: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-5.4/101/

@tklauser tklauser mentioned this pull request Dec 13, 2021
Closed
@tklauser
Copy link
Member Author

test-1.20-4.9 failed on #17010 which will be fixed on v1.11 once #18232 with a backport of #18133 is merged. All other tests passed and requested reviewers approved, marking as ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 13, 2021
@nbusseneau nbusseneau merged commit 5af736a into v1.11 Dec 13, 2021
@nbusseneau nbusseneau deleted the pr/tklauser/v1.11-go-1.17.5 branch December 13, 2021 15:15
@joestringer joestringer mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@christarazi christarazi christarazi approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tklauser @joestringer @christarazi @nbusseneau @michi-covalent