docs: Warn against Helm's --reuse-values in Cilium upgrades
#18259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
area/documentation
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
gandro
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
gandro
force-pushed
the
pr/gandro/docs-helm-warning-against-reuse-values
branch
from
3060977
to
fc2203d
Compare
qmonnet
requested changes
Dec 14, 2021
gandro
force-pushed
the
pr/gandro/docs-helm-warning-against-reuse-values
branch
from
fc2203d
to
867a769
Compare
Using it to upgrade to a new minor Cilium version has never been supported and may break the Helm template in subtle ways due to the lack of default values. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/docs-helm-warning-against-reuse-values
branch
from
867a769
to
6ae2ff6
Compare
nbusseneau
approved these changes
Dec 15, 2021
2 tasks
joestringer
approved these changes
Dec 15, 2021
gandro
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.7
tklauser
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.7
This was referenced Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
--reuse-valuesto upgrade to a new minor Cilium version is never been supported and may break the Helm template in subtle ways due to the lack of new default values. Adding this in the docs after a user on Slack reported multiple problems by using this flag, as supporting the flag in the chart is a rather large task and likely requires some automation and testing to ensure it remains supported.For more details, see also helm/helm#3957 (comment)