-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update the kind documentation with cgroup requirements #18269
Merged
christarazi
merged 1 commit into
cilium:master
from
aditighag:pr/aditighag/extend-kind-cgroup-doc
Jan 5, 2022
Merged
docs: Update the kind documentation with cgroup requirements #18269
christarazi
merged 1 commit into
cilium:master
from
aditighag:pr/aditighag/extend-kind-cgroup-doc
Jan 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditighag
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Dec 15, 2021
qmonnet
reviewed
Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. I have some minor, nitpick-level suggestions, but you may chose to ignore them.
Second sentence in your commit description is missing a verb.
aditighag
force-pushed
the
pr/aditighag/extend-kind-cgroup-doc
branch
from
December 16, 2021 20:46
5525097
to
ef4ad24
Compare
qmonnet
approved these changes
Dec 20, 2021
qmonnet
reviewed
Dec 20, 2021
For kube-proxy replacement (specifically, socket-based load-balancing) to work correctly in KIND clusters, the BPF cgroup programs need to be attached at the correct cgroup hierarchy. For this to happen, the KIND nodes need to have their own separate cgroup namespace. More details in PR - cilium#16259. While cgroup namespaces are supported across both cgroup v1 and v2 modes, container runtimes like Docker enable private cgroup namespace mode by default only with cgroup v2 [1]. With cgroup v1, the default is host cgroup namespace, whereby KIND node containers (and also cilium agent pods) are created in the same cgroup namespace as the underlying host. [1] https://docs.docker.com/config/containers/runmetrics/#running-docker-on-cgroup-v2 Signed-off-by: Aditi Ghag <aditi@cilium.io>
aditighag
force-pushed
the
pr/aditighag/extend-kind-cgroup-doc
branch
from
January 3, 2022 23:41
c046af4
to
af07440
Compare
aditighag
added
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
needs-backport/1.10
labels
Jan 3, 2022
joestringer
added
backport-done/1.11
The backport for Cilium 1.11.x for this PR is done.
and removed
backport-pending/1.11
labels
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-done/1.11
The backport for Cilium 1.11.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For kube-proxy replacement (specifically, socket-based load-balancing)
to work correctly in KIND clusters, the BPF cgroup programs need to be
attached at the correct cgroup hierarchy. For this to happen, the KIND
nodes need to have their own separate cgroup namespace.
More details in PR - #16259.
While cgroup namespaces are supported across both cgroup v1 and v2 modes,
container runtimes like Docker enable private cgroup namespace mode
by default only with cgroup v2 [1]. With cgroup v1, the default is host
cgroup namespace, whereby KIND node containers (and also cilium agent pods)
are created in the same cgroup namespace as the underlying host.
[1] https://docs.docker.com/config/containers/runmetrics/#running-docker-on-cgroup-v2
Signed-off-by: Aditi Ghag aditi@cilium.io