Bpf logrus.WithFields fixups #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raybejjani
added
the
kind/enhancement
joestringer
approved these changes
Oct 24, 2017
pkg/maps/lbmap/lbmap.go
Outdated
| @@ -216,7 +223,9 @@ func UpdateRevNat(key RevNatKey, value RevNatValue) error { | |||
| } | |||
|
|
|||
| func DeleteRevNat(key RevNatKey) error { | |||
| log.Debugf("deleting RevNatKey: %s", key.String()) | |||
| log.WithFields(log.Fields{ | |||
| "revNATK": key, | |||
There was a problem hiding this comment.
UpdateRevNat seems to use logfields.BPFMapKey, any reason not to use it here as well?
There was a problem hiding this comment.
Nope! I missed it when I decided have a global BPFMapKey. Fixed
Signed-off-by: Ray Bejjani <ray@covalent.io>
Signed-off-by: Ray Bejjani <ray@covalent.io>
Signed-off-by: Ray Bejjani <ray@covalent.io>
Signed-off-by: Ray Bejjani <ray@covalent.io>
Signed-off-by: Ray Bejjani <ray@covalent.io>
raybejjani
force-pushed
the
bpf-log-with-fields
branch
from
aa38fec
to
28f7237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches a bunch of log callsites to use logrus.WIthFields. These changes are not supposed to break anything and follow the same reasoning from #1801 The goal of these changes is to make debugging via logs easier by making our usage more consistent. Ideally, field names should be used the same way throughout the code and mean the same thing.
The most important things to review are whether the field names make sense in the context they're used, and whether we should introduce new ones to pkg/logfields/logfields.go. I'm also happy to incorporate better messages into this PR :)