MaintainIPPool refactor and support for aborting release handshake #18330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
hemanthmalla
force-pushed
the
hemanthmalla/refactor_abort
branch
from
6621042
to
22315d9
Compare
gandro
added
area/eni
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
gandro
reviewed
Dec 23, 2021
hemanthmalla
force-pushed
the
hemanthmalla/refactor_abort
branch
from
22315d9
to
53f626a
Compare
|
@gandro Thanks for the review 🙇 |
|
/ci-eks |
|
/test-runtime |
gandro
approved these changes
Dec 23, 2021
|
/test-runtime |
… node Imagine a scenario where a node has 2 unused IPs and pre-allocate set to 1. Let's say one of the IPs is in the middle of a handshake and a new pod is scheduled on the node. The other unused IP would be allocated to the pod. Now, when the operator re-evaluates, the node is no longer considered to be in excess. Without this commit, the operator does not act further on IPs in this state. This results in a scenario where no new IPs are allocated to the node and agent cannot allocate the unused IPs because they're in the middle of a handshake. Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com>
hemanthmalla
force-pushed
the
hemanthmalla/refactor_abort
branch
from
53f626a
to
ef5ed6b
Compare
twpayne
approved these changes
Jan 4, 2022
twpayne
added
the
ready-to-merge
christarazi
reviewed
Jan 5, 2022
christarazi
removed
the
ready-to-merge
|
Given the current title of the PR plus the labels, if we merge & backport & release this as part of v1.11.1, then the PR will show up in the release notes under "Bugfixes" as |
…ol() With the addition of IP release handhake, maintainIPPool() became too long and not very readable. So, moving release and allocate logic into their own functions. Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com>
Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com>
hemanthmalla
force-pushed
the
hemanthmalla/refactor_abort
branch
from
ef5ed6b
to
ef6b386
Compare
christarazi
approved these changes
Jan 5, 2022
|
@christarazi @joestringer Updated the commit message and added a release note. |
|
I see that this was previously marked |
joestringer
added
backport-done/1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine a scenario where a node has 2 unused IPs and pre-allocate set to one. Let's say one of the IPs is in the middle of a handshake and a new pod is scheduled on the node. The other unused IP would be allocated to the pod. Now, when the operator re-evaluates, the node is no longer considered to be in excess. Without this commit, the operator does not act further on IPs in this state. This results in a scenario where no new IPs are allocated to the node and agent cannot allocate the unused IPs because they're in the middle of a handshake.
Also refactors IP release and allocate functionality out of maintainIPPool()