v1.11 ci: set PR base for codeql workflow #18368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following reported issue [1]:
1 issue was detected with this workflow: Please make sure that every
branch in on.pull_request is also in on.push so that Code Scanning
can compare pull requests against the state of the base branch.
[1] https://github.com/cilium/cilium/actions/runs/1591471691
Note that each release branch and master have their own version of this
workflow and on.{pull_request,push}.branches needs to be changed
accordingly.
Signed-off-by: Tobias Klauser <tobias@cilium.io>
This fixes the following error on scheduled runs:
This action requires 'base' input to be configured or 'repository.default_branch' to be set in the event payload"
This also makes sure only code changed by the CL is flagged by CodeQL,
but not existing issues in the repo.
Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
area/CI
christarazi
approved these changes
Jan 4, 2022
aanm
approved these changes
Jan 5, 2022
tklauser
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #18283 with adjusted branch name.
This makes sure only code changed by the CL is flagged by CodeQL,
but not existing issues in the repo.
Moreover, run the paths-filter action only on pull_request events. This
should fix scheduled run of the workflow.