Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.10: Update Go to 1.16.13 #18415

Merged
merged 2 commits into from
Jan 17, 2022
Merged

v1.10: Update Go to 1.16.13 #18415

merged 2 commits into from
Jan 17, 2022

Conversation

tklauser
Copy link
Member

No description provided.

@tklauser tklauser added kind/backports This PR provides functionality previously merged into master. release-note/misc This PR makes changes that have no direct user impact. backport/1.10 labels Jan 10, 2022
@tklauser tklauser temporarily deployed to release-base-images January 10, 2022 09:36 Inactive
@tklauser tklauser force-pushed the pr/tklauser/v1.10-update-go-1.16.13 branch from dcb1800 to 4bc8a2a Compare January 10, 2022 09:50
@tklauser tklauser force-pushed the pr/tklauser/v1.10-update-go-1.16.13 branch from 4bc8a2a to 40731ed Compare January 10, 2022 09:51
@tklauser tklauser temporarily deployed to release-base-images January 10, 2022 09:51 Inactive
@tklauser tklauser temporarily deployed to release-base-images January 10, 2022 09:51 Inactive
@tklauser tklauser force-pushed the pr/tklauser/v1.10-update-go-1.16.13 branch from 40731ed to 0fbafb5 Compare January 10, 2022 09:58
@tklauser tklauser force-pushed the pr/tklauser/v1.10-update-go-1.16.13 branch from 0fbafb5 to 3202cee Compare January 10, 2022 09:59
@tklauser tklauser marked this pull request as ready for review January 10, 2022 09:59
@tklauser tklauser requested review from a team as code owners January 10, 2022 09:59
@tklauser
Copy link
Member Author

tklauser commented Jan 10, 2022 •
edited by maintainer-s-little-helper bot

/test-backport-1.10

Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sChaosTest Connectivity demo application Endpoint can still connect while Cilium is not running

Failure Output

FAIL: Found 1 k8s-app=cilium logs matching list of errors that must be investigated:

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-GKE so I can create a new GitHub issue to track it.

Job 'Cilium-PR-Runtime-net-next' hit: #17629 (98.39% similarity)

@maintainer-s-little-helper maintainer-s-little-helper bot mentioned this pull request Jan 10, 2022
Closed
@tklauser tklauser force-pushed the pr/tklauser/v1.10-update-go-1.16.13 branch from 3202cee to 11f041f Compare January 12, 2022 09:10
@tklauser
Copy link
Member Author

tklauser commented Jan 12, 2022 •
edited by maintainer-s-little-helper bot

/test-backport-1.10

rebased to pick up python3 fix

Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sChaosTest Connectivity demo application Endpoint can still connect while Cilium is not running

Failure Output

FAIL: Found 1 k8s-app=cilium logs matching list of errors that must be investigated:

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-GKE so I can create a new GitHub issue to track it.

@tklauser
Copy link
Member Author

tklauser commented Jan 12, 2022 •
edited by maintainer-s-little-helper bot

/test-backport-1.10

Job 'Cilium-PR-K8s-1.16-net-next' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with direct routing Tests NodePort

Failure Output

FAIL: Can not connect to service "tftp://192.168.36.12:30184/hello" from outside cluster (1/10)

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.16-net-next so I can create a new GitHub issue to track it.

@tklauser
Copy link
Member Author

tklauser commented Jan 13, 2022 •
edited by maintainer-s-little-helper bot

/mlh new-flake Cilium-PR-K8s-1.16-net-next

👍 created #18466

@tklauser
Copy link
Member Author

tklauser commented Jan 13, 2022 •
edited

GKE failure is #18285, opened #18466 for the net-next failure is #12511. Other tests passed and reviews are in, marking as ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 13, 2022
@aditighag aditighag added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jan 14, 2022
@tklauser
Update Go to 1.16.13
90df0ce 
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/tklauser/v1.10-update-go-1.16.13 branch from 11f041f to c08cc10 Compare January 17, 2022 09:33
@tklauser tklauser temporarily deployed to release-base-images January 17, 2022 09:33 Inactive
@tklauser tklauser removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. labels Jan 17, 2022
@tklauser tklauser force-pushed the pr/tklauser/v1.10-update-go-1.16.13 branch from c08cc10 to 2873b11 Compare January 17, 2022 09:43
@tklauser tklauser temporarily deployed to release-base-images January 17, 2022 09:43 Inactive
@tklauser tklauser temporarily deployed to release-base-images January 17, 2022 09:43 Inactive
@tklauser
images: update cilium-{runtime,builder} for Go 1.16.13
bcf4845 
While at it also bump the ubuntu:20.04 image to latest version to pick
up updated systemd packages.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/tklauser/v1.10-update-go-1.16.13 branch from 2873b11 to bcf4845 Compare January 17, 2022 09:51
@tklauser tklauser temporarily deployed to release-base-images January 17, 2022 09:51 Inactive
@tklauser tklauser temporarily deployed to release-base-images January 17, 2022 09:51 Inactive
@tklauser
Copy link
Member Author

/test-backport-1.10

@tklauser
Copy link
Member Author

tklauser commented Jan 17, 2022 •
edited

/test-1.17-4.9

Previous run timed out: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.17-kernel-4.9/474/console do we need to bump timeout somewhere?

@nbusseneau
Copy link
Member

@tklauser The job started around 1100 and got timed out around 1500, it definitely is not normal for a job to run this long (our pipelines typically take 1h30-2h, not 4h), so I would be rather we understand why it took that long and hopefully fix that rather than increase the timeout 😅

@aanm aanm merged commit 67545c3 into v1.10 Jan 17, 2022
@aanm aanm deleted the pr/tklauser/v1.10-update-go-1.16.13 branch January 17, 2022 16:40
@joestringer joestringer mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

@joestringer joestringer Awaiting requested review from joestringer

Assignees

@joestringer joestringer

Labels
kind/backports This PR provides functionality previously merged into master. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tklauser @nbusseneau @pchaigno @joestringer @aanm @aditighag