[v1.11] Backport of #18333 #18464
Merged
[v1.11] Backport of #18333 #18464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit fdf78f0 ] It was not clear that the Curl*() helpers were expecting the first parameter to be a format string (fmt.Sprintf()) if multiple parameters are passed (for additional args to `curl`). Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit e742f50 ] This commit makes a few changes to the Policies suite which will be useful in the subsequent commit. * Extract common functions from Policies suite to be used outside of the Describe block * Converge existing testCurlFromOutside() usage from the Services suite Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added
backport/1.11
|
/test-backport-1.11 |
[ upstream commit a6f9905 ] [ Backporter's notes: The v1.11 tree doesn't have helpers.GetFirstNodeWithoutCilium(), so the conflict resolution was to use helpers.GetNodeWithoutCilium(). ] This test covers both cases where the kube-apiserver is within the cluster or outside of the cluster. This commit adds a second Describe block to the Policies, see comment on top of the second Describe block for why. Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/v1.11-backport-2022-01-12
branch
from
8b39362
to
be5e803
Compare
|
/test-backport-1.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via: