v1.9: docs: Fix cilium-runtime image bump instructions #18491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
backport/1.9
kind/backports
This is a process that reliably works, unlike the previous one which relies on Quay.io's ability to pull images from DockerHub. It does require a core maintainer to prepare the changes, but that's fine for now since v1.9 should change infrequently now. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
submit/joe/update-v1.9-image-bump-instructions
branch
from
932921e
to
cee633a
Compare
aditighag
reviewed
Jan 14, 2022
|
|
||
| 8. After selecting your branch click on "Start Build". | ||
| $ skopeo login docker.io |
There was a problem hiding this comment.
Does it ask prompt for a username?
There was a problem hiding this comment.
I think so, though I don't know what kind of configuration I may have prepared locally to make this work. I'd imagine that if someone other than Andre / I need to follow these instructions, then hopefully this step will at least ensure that they figure out how to set up skopeo correctly.
That said, this is only applicable for v1.9 as the newer branches have better infrastructure in the tree for handling these updates so we don't need to rely on developers having direct access to the upstream container repositories.
aanm
approved these changes
Jan 17, 2022
|
cc @tklauser FYI this will only be for the v1.9 branch. |
tklauser
approved these changes
Jan 17, 2022
|
Only doc changes no need to re-run the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a process that reliably works, unlike the previous one which
relies on Quay.io's ability to pull images from DockerHub. It does
require a core maintainer to prepare the changes, but that's fine for
now since v1.9 should change infrequently now.