daemon: Fix missing errors in KPR init #18499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
kind/bug
The db5300d commit normalized the KPR initialisation routines by making them to return an error. Unfortunately, in some error returns it forgot to add actual errors. This makes debugging of KPR init difficult. For instance: "Detected devices" devices="[enp0s9 eth0]" <..> "failed to finalise LB initialization: Cannot retrieve enp0s9 link" The actual error for the link retrieval is missing. Fixes: db5300d ("choir: normalize error handling in kube_proxy_replacement.go") Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
No need to run the whole CI suite. The conformance should give the coverage. |
brb
added
the
ready-to-merge
glibsm
added
backport-done/1.11
joestringer
moved this from Needs backport from master
to Backport done to v1.11
in 1.11.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The db5300d commit normalized the KPR initialisation routines by
making them to return an error. Unfortunately, in some error returns
it forgot to add actual errors. This makes debugging of KPR init
difficult. For instance:
The actual error for the link retrieval is missing.
Fixes: db5300d ("choir: normalize error handling in kube_proxy_replacement.go")
Signed-off-by: Martynas Pumputis m@lambda.lt