Fix local redirect policies selecting host networked pods #18563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditighag
added
kind/bug
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
aditighag
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
aditighag
added
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test Job 'Cilium-PR-K8s-1.23-kernel-net-next' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment |
joestringer
requested changes
Jan 20, 2022
There was a problem hiding this comment.
LGTM. One minor nit, the last commit refers to commit 3805bae724e7 but github doesn't recognize it. Is that meant to be 0ab4fa1 ?
Yes, I've already fixed it in both PR and commit descriptions. Was waiting to push the latest commits until the ongoing CI run is complete. Check patch is failing for the same reason. |
|
net-next hit #18520. All other tests passed. |
tklauser
approved these changes
Jan 21, 2022
aditighag
force-pushed
the
pr/aditighag/lrp-watcher-regression-fix
branch
from
59d5a1d
to
25dcbb0
Compare
|
Only updated the commit message, no need to run the full CI again. |
|
4.19 hit #18566 All other tests passed.
|
Signed-off-by: Aditi Ghag <aditi@cilium.io>
The configuration option is moved from extra args - https://artifacthub.io/packages/helm/uswitch/kiam/5.9.0. Signed-off-by: Aditi Ghag <aditi@cilium.io>
aanm
requested changes
Jan 26, 2022
Commits da35c88 and 0ab4fa1 introduced a regression for local-redirect use cases like kiam, whereby host networked pod updates were skipped. As a result, node-local redirection for cases where LRPs select host networked pods as backends broke. Tested the fix on an EKS configured with kiam setup. Fixes: da35c88 ("k8s/watchers: don't silently ignore (*K8sWatcher).updatePodHostData error") Fixes: 0ab4fa1 (pkg/k8s: ignore certain ipcache errors) Fixes: cilium#16920 Signed-off-by: Aditi Ghag <aditi@cilium.io>
Test kiam like use cases (LRP select host networked pods) with an address matcher LRP - https://docs.cilium.io/en/latest/gettingstarted/local-redirect-policy/#addressmatcher. Signed-off-by: Aditi Ghag <aditi@cilium.io>
Signed-off-by: Aditi Ghag <aditi@cilium.io>
aditighag
force-pushed
the
pr/aditighag/lrp-watcher-regression-fix
branch
from
568cd70
to
6769ab0
Compare
|
@aanm Are you planning to review this PR further? Other reviews are in, and your review comments have been addressed. |
aanm
approved these changes
Jan 31, 2022
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.8
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.11.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.8
joamaki
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.11
in 1.11.2
This was referenced Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Fixes: da35c88 ("k8s/watchers: don't silently ignore (*K8sWatcher).updatePodHostData error")
Fixes: 0ab4fa1 ("pkg/k8s: ignore certain ipcache errors")
Related: #16920
Release note