-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
route: sort by priority to identify the default one #18564
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joamaki
approved these changes
Jan 21, 2022
a059b83
to
b71aeec
Compare
b71aeec
to
35b0cd5
Compare
In lookupDefaultRoute(), to determine the default route for a given IP family we list all routes filtering just by the 0.0.0.0 destination. On some EKS setups where multilple NICs are attached to an instance, this is not enough to identify a single route, since each interface has its own default route. The following example illustrates the problem: $ ks exec ds/cilium -- ip route list default via 10.100.1.1 dev eth0 default via 10.100.255.65 dev eth1 metric 10001 169.254.169.254 dev eth0 This will cause the agent to report a fatal error, as it can't find a single gateway: cilium-agent level=fatal msg="Error while creating daemon" error="unable to install ip rule for ENI multi-node NodePort: failed to find interface with default route: Found default routes with different netdev ifindices: 2 vs 3" subsys=daemon To address this issue, this commit changes the logic of lookupDefaultRoute() to pick the one with the lowest priority. Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
35b0cd5
to
dacb326
Compare
Job 'Cilium-PR-K8s-1.23-kernel-net-next' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment |
Member
Author
/test Job 'Cilium-PR-K8s-1.23-kernel-net-next' hit: #18566 (97.36% similarity) |
joamaki
approved these changes
Jan 21, 2022
gandro
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/eni
Impacts ENI based IPAM.
backport-done/1.11
The backport for Cilium 1.11.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/bug
This PR fixes an issue in a previous release of Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In lookupDefaultRoute(), to determine the default route for a given IP
family we list all routes filtering just by the 0.0.0.0 destination.
On some EKS setups where multilple NICs are attached to an instance,
this is not enough to identify a single route, since each interface has
its own default route.
The following example illustrates the problem:
This will cause the agent to report a fatal error, as it can't find a
single gateway:
To address this issue, this commit changes the logic of
lookupDefaultRoute() to pick the one with the lowest priority.