node: Fix bug where node ipsets are never cleaned #18582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a typo in the condition for the removal of IP addresses from the node ipset in commit 9708e5d ("node: Don't skip masquerading for External node IPs"), the ipsets would have never been cleaned up. This commit fixes it. Fixes: 9708e5d ("node: Don't skip masquerading for External node IPs") Reported-by: Kornilios Kourtis <kornilios@isovalent.com> Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
the
release-note/misc
|
/test |
joamaki
approved these changes
Jan 25, 2022
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
Added |
glibsm
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.11
in 1.11.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a typo in the condition for the removal of IP addresses from the node ipset in commit 9708e5d ("node: Don't skip masquerading for External node IPs"), the ipsets would have never been cleaned up. This commit fixes it.
Not flagging as bug since it didn't made it into any release yet.
Fixes: #18483.