-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Hands-on tutorial #18583
docs: add Hands-on tutorial #18583
Conversation
Commit 4ca1bddcf1879a1983f4d6d4585fe52e31eef9c2 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commit 4ca1bddcf1879a1983f4d6d4585fe52e31eef9c2 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
1 similar comment
Commit 4ca1bddcf1879a1983f4d6d4585fe52e31eef9c2 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, and thanks a lot for the PR!
I think it is a good idea to have this link on this page, because it's definitely an interesting resource to dive deeper into Cilium. However, this itemised list is specifically about the different sections of the documentation, and the Instruqt classes are not exactly part of it.
My opinion would be to move this right below the list (just above the “Getting Started“ title), as a non-indented sentence. What do you think? @joestringer (as a member of cilium/docs-structure
), what would you say, I think it's OK to have this link on the front page?
On another note, can you please squash your commits into a single one, and add a Sign-off-by:
tag to your commit description as explained in the automatic messages above?
10f5e10
to
eabd727
Compare
Hello @qmonnet, thanks a lot for the comment! |
Commit 0eb2121bd3b219c7788a4cd41815be52dcb1d6fc does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
0eb2121
to
18787aa
Compare
The changes look good to me, thank you. Would you mind squashing your commits once more, please? Please also mind that the
it should be:
This is what causes the Checkpatch action to fail with:
|
Add the following text to documentation: Hands-on tutorial in a live environment to quickly get started with Cilium. Signed-off-by: Van Le <vannnyle@gmail.com>
ad75308
to
e15f73d
Compare
@qmonnet Thank you for the detailed comment on how to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good, thank you!
Thanks for the help! |
This pull request adds the following text to documentation after the line Getting Started Guides:
"Hands-on tutorial in a live environment to quickly get started with Cilium."
Signed-off-by: Van Le vannnyle@gmail.com