daemon: Allow to enable PCAP recorder in non-lb mode #18592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
kind/enhancement
borkmann
approved these changes
Jan 24, 2022
Previously, the PCAP recorder [1] was enabled only when running the
lb-only mode. However, there was an ask from users, who are running KPR
in the XDP mode, to have means to observe the LB traffic (tcpdump
cannot be used for XDP progs).
Why we didn't allow it before? Our main concern was potential verifier
complexity issues. But considering that the opt is disabled by default,
it's up to a user to take the potential risk.
Tested manually on the 5.16 kernel with the following cmds:
./daemon/cilium-agent --debug=true --enable-ipv4=true
--enable-ipv6=false --disable-envoy-version-check=true
--tunnel=disabled --k8s-kubeconfig-path=/home/vagrant/.kube/config
--kube-proxy-replacement=strict --native-routing-cidr=10.154.0.0/16
--enable-ipv4-masquerade=true --auto-direct-node-routes=true
--enable-hubble=true --enable-recorder=true --bpf-lb-acceleration=native
--bpf-lb-acceleration=testing-only
# create nginx pod and expose it via NodePort service
hubble record --server=unix:///var/run/cilium/hubble.sock "0.0.0.0/0
0 192.168.34.11/32 31894 TCP"
# access the svc from outside
2022-01-24T10:25:03Z Status: 14 packets (1106 bytes) written
[1]: https://cilium.io/blog/2021/05/20/cilium-110#pcap
Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
No need to run the full CI. |
brb
added
the
ready-to-merge
glibsm
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.11
in 1.11.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the PCAP recorder [1] was enabled only when running the
lb-only mode. However, there was an ask from users, who are running KPR
in the XDP mode, to have means to observe the LB traffic (tcpdump
cannot be used for XDP progs).
Why we didn't allow it before? Our main concern was potential verifier
complexity issues. But considering that the opt is disabled by default,
it's up to a user to take the potential risk.
Tested manually on the 5.16 kernel with the following cmds:
[1]: https://cilium.io/blog/2021/05/20/cilium-110#pcap