hubble/recorder: Sanitize pcap filename #18612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
release-note/bug
borkmann
approved these changes
Jan 25, 2022
rolinh
changed the title
This removes any special characters from the generated pcap filename. This fixes a bug where we accidentally added a slash to the filename when we added support for the cluster name. This broke file creation, as file names cannot contain slashes. Fixes: 3203df9 ("hubble: Hubble node_name field should contain cluster name") Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/fix-pcap-recorder-slashes
branch
from
ff4926f
to
a25a479
Compare
|
/test Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment Job 'Cilium-PR-K8s-1.23-kernel-net-next' has 2 failures but they might be new flakes since it also hit 1 known flakes: #18566 (96.68) |
rolinh
approved these changes
Jan 25, 2022
|
/test-1.23-net-next |
|
GKE test failure (linked above) is unrelated, as the code modified by this PR is not active in that test suite at all and doesn't affect connectivity either. Marking ready to merge. |
gandro
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.11.2
joamaki
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.11
in 1.11.2
|
Marking for backport to v1.10 too. Sanitizing the file path is something we should always do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes any special characters from the generated pcap filename.
This fixes a bug where we accidentally added a slash to the filename
when we added support for the clustername. This broke file creation, as
file names cannot contain slashes.
Fixes: 3203df9 ("hubble: Hubble node_name field should contain cluster name")
Signed-off-by: Sebastian Wicki sebastian@isovalent.com