#18554 v1.10 backport #18617
#18554 v1.10 backport #18617
Conversation
jibi
added
kind/backports
|
/test-backport-1.10 |
| @@ -4,6 +4,7 @@ on: | |||
| pull_request: | |||
| branches: | |||
| - v1.10 | |||
| - ft/v1.10/** | |||
| push: | |||
| branches: | |||
| - v1.10 | |||
There was a problem hiding this comment.
@jibi 👋 I'm going over the v1.11 backport of the same patch, and was wondering whether we need to add a line under branches here as well?
i.e.,
branches:
- v1.10
- ft/v1.10/**
in the case of 1.10.
There was a problem hiding this comment.
Yes, for v1.11 we'll need to change that to ft/v1.11/**
[ upstream commit c7d9836 ] This commit enables CI for all feature branches based on the v1.10 one. The naming convention for the base feature branch is: ft/v1.10/<feature> Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
jibi
force-pushed
the
pr/jibi/1.10-backport-18554
branch
from
70d7802
to
ba16997
Compare
| #. Fork the Cilium repository to your GitHub user or organization. | ||
| #. Turn off GitHub actions for your fork as described in the `GitHub Docs <https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#managing-github-actions-permissions-for-your-repository>`_. | ||
| #. This is recommended to avoid unnecessary CI notification failures on the fork. | ||
| #. Clone your ``${YOUR_GITHUB_USERNAME_OR_ORG}/cilium`` fork into your ``GOPATH``, and setup the base repository as ``upstream`` remote: |
There was a problem hiding this comment.
I'm not sure we should update the documentation for the backports 🤔
There was a problem hiding this comment.
Yeah, on a second thought I should probably not. Let me get rid of it
[ upstream commit cc85af8 ] Currently CI will run only on the base cilium/cilium repo, due to a check in most workflows in the form of: if: ${{ github.repository == 'cilium/cilium' }} The original intent of this check was to avoid running CI on forks, since workflow secrets are usually not configured, resulting in multiple failures. It turned out that the ability to run CI on forks is something useful to have, and as a bonus point it would ease the development and maintenance of new and existing workflows. Because of this, this commit removes the aforementioned check. Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
jibi
force-pushed
the
pr/jibi/1.10-backport-18554
branch
from
ba16997
to
9383263
Compare
|
/test-backport-1.10 Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment Job 'Cilium-PR-K8s-1.17-kernel-4.9' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment |
|
Couple of unrelated flakes, marking as ready to merge |
jibi
added
the
ready-to-merge
Once this PR is merged, you can update the PR labels via: