Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix incorrect values for hubble-ui standalone install #18661

Merged
merged 1 commit into from
Feb 14, 2022
Merged

docs: Fix incorrect values for hubble-ui standalone install #18661

merged 1 commit into from
Feb 14, 2022

Conversation

ysksuzuki
Copy link
Member

@ysksuzuki ysksuzuki commented Jan 29, 2022 •
edited
Loading

This PR fixes incorrect values given in the document for hubble-ui standalone install.

Fixes: #18650

Signed-off-by: Yusuke Suzuki yusuke-suzuki@cybozu.co.jp

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

@ysksuzuki ysksuzuki requested a review from a team as a code owner January 29, 2022 02:03
@ysksuzuki ysksuzuki requested review from a team and qmonnet January 29, 2022 02:03
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 29, 2022
@ysksuzuki
docs: Fix incorrect values for hubble-ui standalone install
4d8fb06 
This PR fixes incorrect values given in the document for hubble-ui
standalone install.

Fixes: cilium#18650

Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp>
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. needs-backport/1.11 release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay labels Jan 31, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 31, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.2 Jan 31, 2022
qmonnet
qmonnet approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the PR!

gandro
gandro approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix! Marking ready to merge, as this is a docs only change

@gandro gandro removed the request for review from jrfastab February 14, 2022 10:57
@gandro gandro added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 14, 2022
@jibi jibi merged commit 1851275 into cilium:master Feb 14, 2022
@jibi jibi mentioned this pull request Feb 14, 2022
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.2 Feb 14, 2022
@jibi jibi added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Feb 16, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.2 Feb 16, 2022
@eddycharly
Copy link
Contributor

eddycharly commented Feb 22, 2022 •
edited
Loading

👍 just noticed the issue

@joestringer joestringer mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
No open projects
1.11.2
Backport done to v1.11
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm template doesn't generate hubble-ui standalone manifest
6 participants
@ysksuzuki @eddycharly @gandro @qmonnet @jibi @jrfastab