docs: Don't rely on assignee filter for reviews
#18676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The review-requested:@me filter lists pull requests that expect a review from you or from any team you belong to. To allow everyone to see only pull requests assigned specifically to them, we had to teach MLH to assign individual reviewers to the pull request and then use assignee:@me instead of review-requested:@me. Now that GitHub has a user-review-requested filter, we don't need to rely on the assignee filter anymore for reviews. To view pull requests assigned specifically to you (and not just to one of the teams you belong to), you can use user-review-request:@me. There is one small difference in behavior between the two filters. assignee:@me would display pull requests you already reviewed but gave a Request changes or Comment review. Conversely, user-review-requested:@me will only display pull requests you haven't reviewed yet or for which the author re-requested a review from you. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
release-note/misc
pchaigno
added a commit
to cilium/github-actions
that referenced
this pull request
Jan 31, 2022
With the introduction of the GitHub filter user-review-requested, we don't need to assign individual reviewers to pull requests anymore. Related: cilium/cilium#18676 Signed-off-by: Paul Chaignon <paul@cilium.io>
qmonnet
approved these changes
Jan 31, 2022
pchaigno
added a commit
to cilium/github-actions
that referenced
this pull request
Feb 3, 2022
With the introduction of the GitHub filter user-review-requested, we don't need to assign individual reviewers to pull requests anymore. Related: cilium/cilium#18676 Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added a commit
to cilium/github-actions
that referenced
this pull request
Feb 3, 2022
With the introduction of the GitHub filter user-review-requested, we don't need to assign individual reviewers to pull requests anymore. Related: cilium/cilium#18676 Signed-off-by: Paul Chaignon <paul@cilium.io>
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.11.2
joamaki
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.11
in 1.11.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
review-requested:@mefilter lists pull requests that expect a review from you or from any team you belong to. To allow everyone to see only pull requests assigned specifically to them, we had to teach MLH to assign individual reviewers to the pull request and then useassignee:@meinstead ofreview-requested:@me.Now that GitHub has a
user-review-requestedfilter, we don't need to rely on the assignee filter anymore for reviews. To view pull requests assigned specifically to you (and not just to one of the teams you belong to), you can useuser-review-request:@me.There is one small difference in behavior between the two filters.
assignee:@mewould display pull requests you already reviewed but gave aRequest changesorCommentreview. Conversely,user-review-requested:@mewill only display pull requests you haven't reviewed yet or for which the author re-requested a review from you.