-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Add values for custom service monitor annotations #18681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍏
As we don't have any tests with |
Travis CI failure seems legit, we might need to run |
Define Helm values to include custom annotations for cilium-agent / cilium-operator / hubble service monitors similar to how you can define custom annotations for other resources. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
482aaa4
to
2850870
Compare
👍 done! |
Define Helm values to include custom annotations for cilium-agent /
cilium-operator / hubble service monitors similar to how you can define
custom annotations for other resources.
Signed-off-by: Michi Mutsuzaki michi@isovalent.com