docs: export KUBECONFIG for cilium-cli with k3s #18697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
area/documentation
Previously, commit 606b5fe ("docs: KUBECONFIG for cilium-cli with k3s") and commit 606b5fe ("docs: KUBECONFIG for cilium-cli with k3s") changed `cilium install` commands to set KUBECONFIG explicitly. However, successive cilium-cli commands (e.g. `cilium status` or `cilium connectivity test` in the getting started guide) will need the corresponding kubeconfig as well. Thus, suggest to `export KUBECONFIG` at the top of the k3s specific guides. For cilium/cilium-cli#696 Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/docs-k3s-set-kubeconfig
branch
from
3c4b423
to
43b2a06
Compare
joestringer
approved these changes
Feb 2, 2022
tklauser
added
the
ready-to-merge
Good point about the dedicated k3s doc. It looks like most of it is already covered in the k3s-specific part of the quick start guide. It looks like the only part missing is the step to install additional k3s nodes which don't looks specific to Cilium, so one could argue this is already covered by the k3s upstream docs. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.8
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.11.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.8
joamaki
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.11
in 1.11.2
This was referenced Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, commit 606b5fe ("docs: KUBECONFIG for cilium-cli with
k3s") and commit 606b5fe ("docs: KUBECONFIG for cilium-cli with
k3s") changed
cilium installcommands to set KUBECONFIG explicitly.However, successive cilium-cli commands (e.g.
cilium statusorcilium connectivity testin the getting started guide) will need thecorresponding kubeconfig as well. Thus, suggest to
export KUBECONFIGat the top of the k3s specific guides.
For cilium/cilium-cli#696