Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove box download timeout in upstream tests #18707

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

nbusseneau
Copy link
Member

This timeout can be too small when the host has to download all boxes due to not having any of the boxes required for the SHA to be tested.

In particular this is prone to happen on backport PRs, since it's more likely for the job to be scheduled on a node that primarily run master pipelines up to that point.

This timeout can be too small when the host has to download all boxes
due to not having any of the boxes required for the SHA to be tested.

In particular this is prone to happen on backport PRs, since it's more
likely for the job to be scheduled on a node that primarily run `master`
pipelines up to that point.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. needs-backport/1.9 labels Feb 4, 2022
@nbusseneau nbusseneau requested a review from a team as a code owner February 4, 2022 17:36
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.8 Feb 4, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.2 Feb 4, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.13 Feb 4, 2022
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume there's no risk that the download hangs in some way?

@nbusseneau
Copy link
Member Author

The other Jenkinsfiles do not have a timeout and we never hit an issue with that. In the worst case it'll hit the global job timeout, but I don't think this ever happened because of the download times, so I think we should be good 😄

@joamaki joamaki merged commit 96f4050 into cilium:master Feb 7, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.8 Feb 7, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.2 Feb 7, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.8 Feb 8, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.8 Feb 8, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.13 Feb 8, 2022
@joamaki joamaki added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.9 and removed backport-pending/1.11 labels Feb 8, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.2 Feb 9, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.2 Feb 9, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.13 Feb 9, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.13 Feb 9, 2022
@nbusseneau
Copy link
Member Author

nbusseneau commented Mar 8, 2022

It appears we've made a mistake in #18741 and this PR was actually not backported to v1.9. I am resetting backport status.

@joestringer This PR was mentioned in the release notes for v1.9.13, but was actually not backported properly and will be instead added to the next round of backports. Just mentioning it in passing, but it's not actually very important since it has no user-facing consequences.

@joestringer
Copy link
Member

CC @joamaki in case you do backports in future, please make sure to update the PR description (both the text and the command for updating the labels) if you remove any PRs. We use that as the source of truth for marking PRs as backported, and for generating release notes.

@nbusseneau
Copy link
Member Author

Just in case: I don't think this was intended and the PR was removed intentionally. I had acked the backport changes myself on the PR, so either I got confused and acked the wrong PR or we mistakenly removed the PR afterwards in a later push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.8
Backport done to v1.10
1.11.2
Backport done to v1.11
1.9.13
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

None yet

6 participants