-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove box download timeout in upstream tests #18707
Conversation
This timeout can be too small when the host has to download all boxes due to not having any of the boxes required for the SHA to be tested. In particular this is prone to happen on backport PRs, since it's more likely for the job to be scheduled on a node that primarily run `master` pipelines up to that point. Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume there's no risk that the download hangs in some way?
The other Jenkinsfiles do not have a timeout and we never hit an issue with that. In the worst case it'll hit the global job timeout, but I don't think this ever happened because of the download times, so I think we should be good 😄 |
It appears we've made a mistake in #18741 and this PR was actually not backported to @joestringer This PR was mentioned in the release notes for |
CC @joamaki in case you do backports in future, please make sure to update the PR description (both the text and the command for updating the labels) if you remove any PRs. We use that as the source of truth for marking PRs as backported, and for generating release notes. |
Just in case: I don't think this was intended and the PR was removed intentionally. I had acked the backport changes myself on the PR, so either I got confused and acked the wrong PR or we mistakenly removed the PR afterwards in a later push. |
This timeout can be too small when the host has to download all boxes due to not having any of the boxes required for the SHA to be tested.
In particular this is prone to happen on backport PRs, since it's more likely for the job to be scheduled on a node that primarily run
master
pipelines up to that point.