Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loader: Fix egress attachment for bandwidth manager #18717

Merged
merged 1 commit into from Feb 8, 2022

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Feb 7, 2022

The loader only attaches BPF programs to the egress of native devices if the host firewall or BPF NodePort are enabled. It is however also necessary to attach on egress if only the bandwidth manager is enabled.

Updates: #16790.

Fix BPF attachment when bandwidth manager is enabled without host firewall or kube-proxy-replacement.

The loader only attaches BPF programs to the egress of native devices if
the host firewall or BPF NodePort are enabled. It is however also
necessary to attach on egress if only the bandwidth manager is enabled.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added kind/bug This is a bug in the Cilium logic. sig/loader Impacts the loading of BPF programs into the kernel. release-note/bug This PR fixes an issue in a previous release of Cilium. feature/bandwidth-manager Impacts BPF bandwidth manager. needs-backport/1.11 labels Feb 7, 2022
@pchaigno pchaigno requested a review from a team as a code owner February 7, 2022 10:37
@pchaigno pchaigno requested a review from ti-mo February 7, 2022 10:37
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.2 Feb 7, 2022
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 7, 2022
@joamaki joamaki merged commit e331b12 into cilium:master Feb 8, 2022
@pchaigno pchaigno deleted the fix-egress-attach-for-bw-manager branch February 8, 2022 10:33
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.2 Feb 11, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 11, 2022
@jibi jibi added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Feb 14, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.2 Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. feature/bandwidth-manager Impacts BPF bandwidth manager. kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/loader Impacts the loading of BPF programs into the kernel.
Projects
No open projects
1.11.2
Backport done to v1.11
Development

Successfully merging this pull request may close these issues.

None yet

5 participants