iptables,option,node: Consistent condition for ipset usage #18788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
kind/bug
maintainer-s-little-helper
bot
added
the
ready-to-merge
nebril
added
the
dont-merge/needs-rebase
This commit fixes a bug where we would create ipsets and fill them with IP addresses even though they would never be used by our iptables rules. To fix this, we introduce a new NodeIpsetNeeded helper function, such that there is a single place where we define whether node ipsets should be used. This helper function is then used both to create ipset iptables rules and add IP addresses to ipsets. Fixes: 49cb220 ("iptables: Don't masquerade traffic to cluster nodes") Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
removed
ready-to-merge
maintainer-s-little-helper
bot
added
the
ready-to-merge
pchaigno
force-pushed
the
fix-condition-for-using-ipset
branch
from
cda325b
to
ef9e67e
Compare
|
/test |
nebril
removed
the
ready-to-merge
maintainer-s-little-helper
bot
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.11.2
joestringer
added
the
backport-done/1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug where we would create ipsets and fill them with IP addresses even though they would never be used by our iptables rules.
To fix this, we introduce a new
NodeIpsetNeededhelper function, such that there is a single place where we define whether node ipsets should be used. This helper function is then used both to create ipset iptables rules and add IP addresses to ipsets.Fixes: #16603.
Related: #18787.