helm: check for contents of bootstartFile #18897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
release-note/bug
sayboras
reviewed
Feb 23, 2022
|
/test Job 'Cilium-PR-K8s-1.23-kernel-net-next' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
sayboras
approved these changes
Feb 23, 2022
kaworu
approved these changes
Feb 23, 2022
nathanjsweet
approved these changes
Feb 23, 2022
pchaigno
added
the
sig/k8s
Checking for the existence of the .Values.nodeinit.bootstrapFile file will be a no-op because the file is created by kubelet if it does not exist. Instead, we should check if the file has some contents inside of it which is when we can be sure the node-init DaemonSet has started. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/fix-bootstrapfile
branch
from
41e54d0
to
60c459b
Compare
|
/test |
|
/ci-multicluster |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.9
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.11.3
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.9
This was referenced Mar 26, 2022
qmonnet
added
backport-done/1.11
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for the existence of the .Values.nodeinit.bootstrapFile
file will be a no-op because the file is created by kubelet if
it does not exist. Instead, we should check if the file has some
contents inside of it which is when we can be sure the node-init
DaemonSet has started.
Signed-off-by: André Martins andre@cilium.io