-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport: Helm Clustermesh and Openshift Backport for 1.10 #18918
Merged
gandro
merged 2 commits into
v1.10
from
pr/nathanjsweet/backport-helm-clustermesh-fixes-to-1-10
Mar 9, 2022
Merged
backport: Helm Clustermesh and Openshift Backport for 1.10 #18918
gandro
merged 2 commits into
v1.10
from
pr/nathanjsweet/backport-helm-clustermesh-fixes-to-1-10
Mar 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd95b0c
to
f2c8596
Compare
f2c8596
to
812472f
Compare
In order to connect Clustermesh clusters without cilium-cli tool we would need to manually patch the cilium agent with hostAliases, configure the cilium-clustermesh secret with mTLS material from the connected clusters. This commit adds support to connect multiple Clustermesh clusters using the Helm Chart. Fixes: #17811 Signed-off-by: Samuel Torres <samuelpirestorres@gmail.com> Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
In order to enable offline deployment for certain platforms (like OpenShift) we need to be able to have a universal override for all images so that the OpenShift certified operator can list its "related images"[1][2]. [1]https://docs.openshift.com/container-platform/4.9/operators/operator_sdk/osdk-generating-csvs.html#olm-enabling-operator-for-restricted-network_osdk-generating-csvs [2]https://redhat-connect.gitbook.io/certified-operator-guide/appendix/offline-enabled-operators Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
812472f
to
efa9a80
Compare
/test-backport-1.10 Job 'Cilium-PR-K8s-GKE' hit: #17628 (95.95% similarity) |
/test-runtime |
/test-gke |
/ci-eks-1.10 |
gandro
approved these changes
Mar 9, 2022
To re-run the failed tests, we would have to rebuild the images. But considering that none of those use clustermesh (and EKS and Runtime don't use Helm), there is no point in re-running them. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via:
or with