Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: Helm Clustermesh and Openshift Backport for 1.10 #18918

Merged

Conversation

nathanjsweet
Copy link
Member

Once this PR is merged, you can update the PR labels via:

$ for pr in 17851 18849; do contrib/backporting/set-labels.py $pr done 1.10; done

or with

$ make add-label branch=v1.10 issues=17851,18849

@nathanjsweet nathanjsweet added kind/backports This PR provides functionality previously merged into master. backport/1.10 labels Feb 23, 2022
@nathanjsweet nathanjsweet requested a review from a team as a code owner February 23, 2022 20:35
@nathanjsweet nathanjsweet changed the title Helm Clustermesh and Openshift Backport for 1.10 backport: Helm Clustermesh and Openshift Backport for 1.10 Feb 23, 2022
@nathanjsweet nathanjsweet force-pushed the pr/nathanjsweet/backport-helm-clustermesh-fixes-to-1-10 branch from bd95b0c to f2c8596 Compare February 23, 2022 20:41
@nathanjsweet nathanjsweet added the dont-merge/blocked Another PR must be merged before this one. label Feb 23, 2022
@nathanjsweet nathanjsweet force-pushed the pr/nathanjsweet/backport-helm-clustermesh-fixes-to-1-10 branch from f2c8596 to 812472f Compare February 23, 2022 22:41
samueltorres and others added 2 commits February 25, 2022 16:43
In order to connect Clustermesh clusters without cilium-cli tool
we would need to manually patch the cilium agent with hostAliases,
configure the cilium-clustermesh secret with mTLS material from
the connected clusters. This commit adds support to connect multiple
Clustermesh clusters using the Helm Chart.

Fixes: #17811

Signed-off-by: Samuel Torres <samuelpirestorres@gmail.com>
Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
In order to enable offline deployment for certain
platforms (like OpenShift) we need to be able to have
a universal override for all images so that
the OpenShift certified operator can list its
"related images"[1][2].

[1]https://docs.openshift.com/container-platform/4.9/operators/operator_sdk/osdk-generating-csvs.html#olm-enabling-operator-for-restricted-network_osdk-generating-csvs
[2]https://redhat-connect.gitbook.io/certified-operator-guide/appendix/offline-enabled-operators

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@nathanjsweet nathanjsweet force-pushed the pr/nathanjsweet/backport-helm-clustermesh-fixes-to-1-10 branch from 812472f to efa9a80 Compare February 25, 2022 22:43
@nathanjsweet nathanjsweet removed the dont-merge/blocked Another PR must be merged before this one. label Feb 25, 2022
@kaworu
Copy link
Member

kaworu commented Feb 28, 2022

/test-backport-1.10

Job 'Cilium-PR-K8s-GKE' hit: #17628 (95.95% similarity)

@gandro
Copy link
Member

gandro commented Mar 7, 2022

/test-runtime

@gandro
Copy link
Member

gandro commented Mar 7, 2022

/test-gke

@gandro
Copy link
Member

gandro commented Mar 7, 2022

/ci-eks-1.10

@gandro
Copy link
Member

gandro commented Mar 9, 2022

To re-run the failed tests, we would have to rebuild the images. But considering that none of those use clustermesh (and EKS and Runtime don't use Helm), there is no point in re-running them. Merging.

@gandro gandro merged commit c04f41e into v1.10 Mar 9, 2022
@gandro gandro deleted the pr/nathanjsweet/backport-helm-clustermesh-fixes-to-1-10 branch March 9, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants