pkg/redirectpolicy: Add missing namespace check in pod update handler #19193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit eb71afb9c3caa488563b96de9eceb5281e1d545a does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
joestringer
approved these changes
Mar 18, 2022
aditighag
force-pushed
the
pr/aditighag/lrp-fix-namespace-check
branch
from
eb71afb
to
af85f46
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
aditighag
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test-only --focus="K8sLRPTests" --kernel_version=net-next |
aditighag
force-pushed
the
pr/aditighag/lrp-fix-namespace-check
branch
from
af85f46
to
03dd99e
Compare
|
/test-only --focus="K8sLRPTests" --kernel_version=net-next Edit : Passed - https://jenkins.cilium.io/job/Cilium-PR-Tests-Kernel-Focus/425/. |
joestringer
approved these changes
Mar 18, 2022
Local Redirect Policy (LRP) namespace needs to match with the backend pods selected by the LRP. This check was missing in the case where backend pods are deployed after an LRP that selects them was applied. Added unit tests. Reported-by: Joe Stringer <joe@covalent.io> Signed-off-by: Aditi Ghag <aditi@cilium.io>
aditighag
force-pushed
the
pr/aditighag/lrp-fix-namespace-check
branch
from
03dd99e
to
0ad534a
Compare
|
/test-only --focus="K8sLRPTests" --kernel_version=net-next |
|
Latest commits only include a documentation change. |
joestringer
approved these changes
Mar 28, 2022
pchaigno
added
backport-done/1.11
joestringer
moved this from Needs backport from master
to Backport done to v1.9
in 1.9.15
joestringer
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.10
joestringer
moved this from Needs backport from master
to Backport done to v1.11
in 1.11.4
This was referenced Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/redirectpolicy: Add missing namespace check
Local Redirect Policy (LRP) namespace needs to match
with the backend pods selected by the LRP.
This check was missing in the case where backend
pods are deployed after an LRP that selects them
was applied.
Reported-By: Joe Stringer joe@covalent.io
Release note