Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: configuration for host-only networks with latest virtualbox #19206

Closed
wants to merge 1 commit into from
Closed

docs: configuration for host-only networks with latest virtualbox #19206

wants to merge 1 commit into from

Conversation

koncha99
Copy link
Contributor

A later version of VirtualBox restricts IP ranges that can be used for host-only
networks by default. Added a note that describes required configuration of
host-only networks to launch VMs with latest VirtualBox.

Signed-off-by: Keisuke Kondok.gryphus@gmail.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #18932

docs: configuration for host-only networks with latest VirtualBox

@koncha99 koncha99 requested review from a team as code owners March 21, 2022 04:02
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 21, 2022
qmonnet
qmonnet requested changes Mar 21, 2022
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution!
Could you please add the link to the reference manual section, in case readers want more details?

Documentation/contributing/development/dev_setup.rst Outdated Show resolved Hide resolved
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Mar 21, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 21, 2022
@koncha99
Copy link
Contributor Author

koncha99 commented Apr 4, 2022 •
edited

@qmonnet Can you take a look at this ?

qmonnet
qmonnet approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I missed you update. Looks good now, thank you! Any chance you could squash your commits into a single one? (Please drop the Co-authored-by tag with my personal email when doing so.)

@koncha99
docs: configuration for host-only networks with latest virtualbox
33d48db 
A later version of VirtualBox restricts IP ranges that can be used for host-only
networks by default. Added a note that describes required configuration of
host-only networks to launch VMs with latest VirtualBox.

Fixes: cilium#18932

Signed-off-by: Keisuke Kondo<k.gryphus@gmail.com>
@koncha99 koncha99 force-pushed the pr/docs-note-for-setup-with-latest-virtualbox branch from af39fc4 to 33d48db Compare April 4, 2022 15:17
@koncha99
Copy link
Contributor Author

koncha99 commented Apr 4, 2022

@qmonnet Thanks! I squshed commits.

pchaigno
pchaigno requested changes Apr 4, 2022
View reviewed changes
Documentation/contributing/development/dev_setup.rst
* FD00::/16
...

See `VirtualBox Host-Only Networking <https://www.virtualbox.org/manual/ch06.html#network_hostonly>`_ for more detail.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you hit this issue and what was the exact error? This should have been fixed in #17900 by using different IP address ranges.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hit an error caused by the restriction of ipv6 addresses as I described in issue, #18932 . I guess that PR only fixed ipv4 addresses. If so, should I fix the script instead of adding a note for the document?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's fix the script instead.

@nbusseneau I assume we'll also need a fix for our CI infrastructure since the fix isn't in v1.9?

Copy link
Member

@nbusseneau nbusseneau Apr 5, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to fix both the dev (top-level) and CI (under /test) Vagrantfile to ensure the IPv6 ranges are sound (if they are not already, which seems the case at least for dev). I recall we discussed that at some point while fixing IPv4, but I never got around to check. Thank you very much for looking into this @koncha99 :)

Note that on top of Vagrantfile configurations, there might be other files that need to be edited (docs, tests, etc. => #17900 might give you a hint at what to look out for).

@koncha99
Copy link
Contributor Author

I"ll close this PR and fix IPv6 address ranges on the script instead. (Thanks, @pchaigno and @qmonnet for reviewing.)

@koncha99 koncha99 closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno requested changes

@nbusseneau nbusseneau nbusseneau left review comments

@qmonnet qmonnet qmonnet approved these changes

@tklauser tklauser Awaiting requested review from tklauser tklauser was automatically assigned from cilium/contributing

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Adding a note for required configuration to create a host-only network with latest VirtualBox
4 participants
@koncha99 @pchaigno @nbusseneau @qmonnet