pkg/k8s: use subresource "nodes/status" to update node annotations #19590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
/test |
aanm
force-pushed
the
pr/trim-down-cilium-clusterrole
branch
from
a90ff4e
to
f1c2c89
Compare
|
/test |
aanm
added
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
sayboras
reviewed
Apr 27, 2022
install/kubernetes/cilium/templates/cilium-agent/clusterrole.yaml
Outdated
Show resolved
Hide resolved
aanm
force-pushed
the
pr/trim-down-cilium-clusterrole
branch
from
f1c2c89
to
6f5b095
Compare
|
/test Job 'Cilium-PR-K8s-1.22-kernel-4.19' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
sayboras
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
LGTM 
$ kg node kind-worker -o json | jq .metadata.annotations
{
"io.cilium.network.ipv4-cilium-host": "10.0.0.227",
"io.cilium.network.ipv4-health-ip": "10.0.0.190",
"io.cilium.network.ipv4-pod-cidr": "10.0.0.0/24",
"kind.x-k8s.io/registry": "localhost:5000",
"kubeadm.alpha.kubernetes.io/cri-socket": "unix:///run/containerd/containerd.sock",
"node.alpha.kubernetes.io/ttl": "0",
"volumes.kubernetes.io/controller-managed-attach-detach": "true"
}
We can use the "status" subresource to update node annotations which also allow us to reduce the clusterrole's permissions of the cilium DaemonSet even further. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/trim-down-cilium-clusterrole
branch
from
6f5b095
to
1add133
Compare
|
/(test-1.22-4.19 |
|
/test-1.22-4.19 |
This was referenced May 3, 2022
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.16
aanm
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.11
in 1.11.5
This was referenced May 9, 2022
Closed
2 tasks
|
✔️ LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use the "status" subresource to update node annotations which
also allow us to reduce the clusterrole's permissions of the cilium
DaemonSet even further.
Signed-off-by: André Martins andre@cilium.io