[v1.9] Backport 19153 #19634
Merged
[v1.9] Backport 19153 #19634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
backport/1.9
kind/backports
christarazi
changed the title
christarazi
force-pushed
the
pr/christarazi/v1.9-backport-go-metrics
branch
2 times, most recently
from
6246f3c
to
e069ba1
Compare
|
/test-backport-1.9 |
aanm
force-pushed
the
pr/christarazi/v1.9-backport-go-metrics
branch
from
e069ba1
to
6d4db78
Compare
christarazi
force-pushed
the
pr/christarazi/v1.9-backport-go-metrics
branch
2 times, most recently
from
341799a
to
1bb619a
Compare
|
/test-backport-1.9 |
|
/test-upstream-k8s |
joestringer
reviewed
Apr 29, 2022
chancez
reviewed
Apr 29, 2022
chancez
reviewed
Apr 29, 2022
There was a problem hiding this comment.
LGTM, but will defer to @joestringer on the protobuf aspect.
|
Noting that all of CI has passed. |
[ upstream commit 6c5e2d6 ] [ Backporter's notes: Needed to bump the Prometheus module in order to make the upstream commit pass Go's mod checks. ] Prometheus provides metrics collectors that expose go runtime and go build information, which can be useful to server administrators, lets expose them. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com> Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/v1.9-backport-go-metrics
branch
from
1bb619a
to
bac65b2
Compare
joestringer
approved these changes
Apr 29, 2022
christarazi
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ upstream commit 6c5e2d6 ]
[ Backporter's notes: Needed to bump the Prometheus module in order to
make the upstream commit pass Go's mod checks. ]
Prometheus provides metrics collectors that expose go runtime and go build
information, which can be useful to server administrators, lets expose
them.
Backport of #19153
Once this PR is merged, you can update the PR labels via: