[v1.10] Backport 19153 #19637
Merged
[v1.10] Backport 19153 #19637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 6c5e2d6 ] [ Backporter's notes: Needed to bump the Prometheus module in order to make the upstream commit pass Go's mod checks. ] Prometheus provides metrics collectors that expose go runtime and go build information, which can be useful to server administrators, lets expose them. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com> Signed-off-by: Chris Tarazi <chris@isovalent.com>
maintainer-s-little-helper
bot
added
backport/1.10
kind/backports
christarazi
changed the title
|
/test-backport-1.10 Edit:
|
aanm
approved these changes
Apr 29, 2022
|
/test-1.20-4.19 |
|
Marking ready to merge as we have approvals and CI has passed except for ci-awscni-1.10 which is broken for v1.10.x runs with the CLI due to the Helm-based install incompatibility. |
christarazi
added
the
ready-to-merge
|
/ci-awscni-1.10 |
aanm
removed
the
ready-to-merge
|
@christarazi I've removed the |
|
@aanm It passed. Ready to merge now? |
|
@christarazi The PR needs to be rebased. |
aditighag
added
the
dont-merge/needs-rebase
|
@aditighag it's not required at this moment as we have a couple backport PRs open. We can merge all of them, if the CI is green, and them run a CI on a draft PR for the stable branch to double check if everything passes before doing a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ upstream commit 6c5e2d6 ]
[ Backporter's notes: Needed to bump the Prometheus module in order to
make the upstream commit pass Go's mod checks. ]
Prometheus provides metrics collectors that expose go runtime and go build
information, which can be useful to server administrators, lets expose
them.
Signed-off-by: Chance Zibolski chance.zibolski@gmail.com
Signed-off-by: Chris Tarazi chris@isovalent.com
Backport of #19153
Once this PR is merged, you can update the PR labels via: