clarify some docs around the kubeProxyReplacement=partial mode #19831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
qmonnet
requested changes
May 16, 2022
qmonnet
added
area/documentation
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
qmonnet
approved these changes
May 16, 2022
|
Can you please squash the two commits? (And drop the |
aecay
force-pushed
the
cilium-docs-node-port-healthcheck-tweak
branch
from
97301f7
to
f1edcdf
Compare
Done (with apologies for the long delay as I've just returned from a long vacation) |
|
This pull request has been automatically marked as stale because it |
github-actions
bot
added
the
stale
|
@aecay it looks there are conflicting files. Could you rebase your PR against the latest changes on master branch? Thank you |
- change how the `enableHealthCheckNodeport` option is spelled - itʼs actually `nodePort.enableHealthCheck` [ref](https://github.com/cilium/cilium/blob/dfa6b157e8e9484c65fd938b2b45a4f5f50c61f9/install/kubernetes/cilium/templates/cilium-configmap.yaml#L591-L593) - change the scope of the recommendation to enable this option - AFAICS itʼs only relevant when `nodePort.enabled` is true - a double-check of this would be welcome (but weʼve been running with `kubeProxyReplacement=partial nodePort.enableHealthCheck=true` with no apparent ill effect) - include a brief explanation of why this setting is required Signed-off-by: Aaron Ecay <aaron.ecay@sky.uk>
aecay
force-pushed
the
cilium-docs-node-port-healthcheck-tweak
branch
from
f1edcdf
to
a23a634
Compare
|
@aanm - thanks. Rebased 👍 |
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enableHealthCheckNodeportoption is spellednodePort.enableHealthCheckrefnodePort.enabledis truekubeProxyReplacement=partial nodePort.enabled=false nodePort.enableHealthCheck=truewith no apparent ill effect...)