ipcache: Error out from InjectLabels if Checker is nil #19887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K8s cache is not fully synced also when k8sSyncedChecker is still nil. Found during code inspection, not sure if this can manifest as a bug on runtime. Fixes: cilium#17823 Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
added
kind/bug
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
jrajahalme
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
joestringer
approved these changes
May 19, 2022
joestringer
added
needs-backport/1.11
and removed
backport/1.11
|
The labels were wrong for backport, this needs backport but this is submitted against master. Fixed. Otherwise LGTM, nice find. |
|
/test |
christarazi
approved these changes
May 25, 2022
|
awscni job failed before starting the actual tests, seems like some issue with the testing scripts or infra. No need to block this on that one failure. Merging. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.11.6
tklauser
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.11
in 1.11.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.11
in 1.11.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K8s cache is not fully synced also when k8sSyncedChecker is still nil.
Found during code inspection, not sure if this can manifest as a bug on
runtime.
Fixes: #17823
Signed-off-by: Jarno Rajahalme jarno@isovalent.com