cli: Use custom named map instead of StringToStringVar

[sayboras]

Description

Out of all the flags having string map type, only these two flags are
StringToStringVar type, which failed validation if the passed value is
json format.

2022-05-26T12:03:33.817769447Z level=fatal msg="Incorrect config-map flag subnet-tags-filter" error="{\"type\":\"private\", \"another\": \"value\" } must be formatted as key=value" subsys=config

Relates: #16014
Fixes: #19961
Signed-off-by: Tam Mach tam.mach@cilium.io

Testing

Testing was done locally before and after for below helm value file.

extraConfig:
  "subnet-tags-filter": "{\"type\":\"private\", \"another\": \"value\" }"
  "api-rate-limit": "{\"endpoint-create\": \"rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true\", \"endpoint-delete\": \"rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true\", \"endpoint-get\": \"rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true\", \"endpoint-list\": \"rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true\", \"endpoint-patch\": \"rate-limit:10/s,rate-burst:10,parallel-requests:10,auto-adjust:true\"}"

[sayboras]

/test

[sayboras]

/test-1.23-net-next

Job 'Cilium-PR-K8s-1.23-kernel-net-next' failed:

Click to show.

Test Name

K8sServicesTest Checks N/S loadbalancing Tests with XDP, direct routing, SNAT and Random

Failure Output

FAIL: Can not connect to service "tftp://[fd04::11]:31667/hello" from outside cluster (4/10)

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.23-kernel-net-next so I can create one.

[gandro]

Thanks for taking care of this.

[sayboras]

/test-1.23-net-next

[sayboras]

Reviews are in, all required tests are passed. Marking this ready to merge.