datapath: Use FROM_NETDEV instead of FROM_LXC in nodeport.h #19986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
sig/datapath
The commit be16f22 ("bpf: Rename tail call targets") did a great job renaming some tail call targets. In particular, s/FROM_LXC/FROM_NETDEV/ in the bpf_host.c. In the similar manner, this commit renames the targets in nodeport.h to remove any ambiguity which might make a reader to think that the tail call was made from bpf_lxc. Also, extend the rev-DNAT comment for a potential NodePort BPF reply from a remote backend. Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
force-pushed
the
pr/brb/fix-np-tail-calls
branch
from
8be5790
to
c13fc67
Compare
|
/test |
pchaigno
approved these changes
May 27, 2022
|
Given this is only a comment change + a constant name change (value is the same) and it all compiles, I don't think we need to wait for the end-to-end tests. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit be16f22 ("bpf: Rename tail call targets") did a great job
renaming some tail call targets. In particular, s/FROM_LXC/FROM_NETDEV/
in the bpf_host.c.
In the similar manner, this commit renames the targets in nodeport.h to
remove any ambiguity which might make a reader to think that the tail
call was made from bpf_lxc.
Also, extend the rev-DNAT comment for a potential NodePort BPF reply
from a remote backend.