Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s: error out when kube-apiserver is unreachable #2014

Merged
merged 1 commit into from
Nov 10, 2017
Merged

k8s: error out when kube-apiserver is unreachable #2014

merged 1 commit into from
Nov 10, 2017

Conversation

aanm
Copy link
Member

@aanm aanm commented Nov 10, 2017 •
edited

Fixes #1973

In kubernetes mode, fixed bug that was allowing cilium to start up even if the kubernetes api-server was not reachable #1973

@aanm
k8s: error out when kube-apiserver is unreachable
9acee80 
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. kind/bug This is a bug in the Cilium logic. pending-review release-note/bug This PR fixes an issue in a previous release of Cilium. labels Nov 10, 2017
@aanm aanm requested a review from a team November 10, 2017 12:44
nebril
nebril approved these changes Nov 10, 2017
View reviewed changes
Copy link
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@tgraf tgraf merged commit 87d005c into master Nov 10, 2017
@tgraf tgraf deleted the 1973-error-out-when-k8s-is-not-reachable branch November 10, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

Assignees
No one assigned
Labels
kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix error message when k8s can't reach the API server
3 participants
@aanm @nebril @tgraf