Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add developers guide page about BPF testing framework #20165

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

dylandreimerink
Copy link
Member

This PR adds a new page to the "For developers/Testing" section.
The page covers how to run and create BPF tests within the framework
that was added in #20017

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 10, 2022
@dylandreimerink dylandreimerink added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jun 10, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 10, 2022
@dylandreimerink dylandreimerink marked this pull request as ready for review June 10, 2022 16:46
@dylandreimerink dylandreimerink requested review from a team as code owners June 10, 2022 16:46
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a few suggestions, and tons of nitpicks; but great work overall!

Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
@dylandreimerink
Copy link
Member Author

I've got a few suggestions, and tons of nitpicks

Ah, I see my English is failing me. Thanks, all of them good suggestions.

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more nits, but thanks a lot for addressing all the previous batch!

Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One left, but all good for me otherwise. Thanks!

Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing a detailed guide! I only followed the first half of the guide.

Documentation/contributing/testing/bpf.rst Show resolved Hide resolved
Documentation/contributing/testing/bpf.rst Outdated Show resolved Hide resolved
This commits adds a new page to the "For developers/Testing" section.
The page covers how to run and create BPF tests within the framework
that was added in cilium#20017

Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 17, 2022
@kkourt kkourt merged commit e48e436 into cilium:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants