Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric for FQDN regex LRU access #20225

Closed
wants to merge 1 commit into from
Closed

Add metric for FQDN regex LRU access #20225

wants to merge 1 commit into from

Conversation

christarazi
Copy link
Member

@christarazi christarazi commented Jun 15, 2022 •
edited

Based on #20516

This commit enables visibility into the FQDN regex compilation LRU by
showing "hit" accesses (cache hit) and "miss" accesses (cache miss).

To enable, the user must enable the metric via --metrics +cilium_fqdn_regex_lru_accesses_total.

Signed-off-by: Chris Tarazi chris@isovalent.com

@christarazi christarazi added area/daemon Impacts operation of the Cilium daemon. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. release-note/misc This PR makes changes that have no direct user impact. labels Jun 15, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 15, 2022
@christarazi christarazi force-pushed the pr/christarazi/fqdn-lru-metrics branch from 2cd20ad to 96f6b17 Compare June 16, 2022 00:05
@christarazi
Copy link
Member Author

christarazi commented Jun 16, 2022 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-GKE' failed:

Click to show.

Test Name

K8sNode Node labels updates are reflected in CiliumNode objects

Failure Output

FAIL: Kubernetes DNS did not become ready in time

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-GKE so I can create one.

@christarazi christarazi marked this pull request as ready for review June 16, 2022 00:41
@christarazi christarazi requested a review from a team as a code owner June 16, 2022 00:41
@christarazi christarazi requested a review from a team June 16, 2022 00:41
@christarazi christarazi requested a review from a team as a code owner June 16, 2022 00:41
@christarazi christarazi force-pushed the pr/christarazi/fqdn-lru-metrics branch from 96f6b17 to 9992437 Compare June 16, 2022 06:12
ungureanuvladvictor
ungureanuvladvictor reviewed Jun 16, 2022
View reviewed changes
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/metrics/metrics.go Show resolved Hide resolved
@christarazi christarazi force-pushed the pr/christarazi/fqdn-lru-metrics branch 2 times, most recently from f5a00eb to 143cb18 Compare June 16, 2022 19:52
@christarazi christarazi requested a review from a team as a code owner June 16, 2022 19:52
@christarazi christarazi changed the title fqdn, metrics: Add metric for FQDN regex LRU access Add metric for FQDN regex LRU access and document existing FQDN metrics Jun 16, 2022
ungureanuvladvictor
ungureanuvladvictor approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@ungureanuvladvictor ungureanuvladvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christarazi
Copy link
Member Author

christarazi commented Jun 16, 2022 •
edited

Nominating for v1.11 and v1.10 backports due to usefulness, especially considering that #19809 and #19857 have been backported.

@christarazi christarazi mentioned this pull request Jun 16, 2022
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.7 Jun 16, 2022
@michi-covalent michi-covalent added this to Needs backport from master in 1.10.18 Nov 15, 2022
@michi-covalent michi-covalent removed this from Needs backport from master in 1.10.17 Nov 15, 2022
@michi-covalent michi-covalent added this to Needs backport from master in 1.11.12 Nov 15, 2022
@michi-covalent michi-covalent removed this from Needs backport from master in 1.11.11 Nov 15, 2022
@github-actions
Copy link

This pull request has not seen any activity since it was marked stale.
Closing.

@github-actions github-actions bot closed this Nov 18, 2022
@joestringer joestringer added this to Needs backport from master in 1.10.19 Dec 15, 2022
@joestringer joestringer removed this from Needs backport from master in 1.10.18 Dec 15, 2022
@joestringer joestringer added this to Needs backport from master in 1.11.13 Dec 15, 2022
@joestringer joestringer removed this from Needs backport from master in 1.11.12 Dec 15, 2022
@joestringer joestringer removed this from Needs backport from master in 1.10.19 Dec 22, 2022
@michi-covalent michi-covalent added this to Needs backport from master in 1.11.14 Jan 26, 2023
@michi-covalent michi-covalent removed this from Needs backport from master in 1.11.13 Jan 26, 2023
@joestringer joestringer added this to Needs backport from master in 1.11.15 Feb 13, 2023
@joestringer joestringer removed this from Needs backport from master in 1.11.14 Feb 13, 2023
@nebril nebril added this to Needs backport from master in 1.11.16 Mar 10, 2023
@nebril nebril removed this from Needs backport from master in 1.11.15 Mar 10, 2023
@michi-covalent michi-covalent added this to Needs backport from master in 1.11.17 Apr 14, 2023
@michi-covalent michi-covalent removed this from Needs backport from master in 1.11.16 Apr 14, 2023
@jrajahalme jrajahalme added this to Needs backport from main in 1.11.18 May 12, 2023
@jrajahalme jrajahalme removed this from Needs backport from main in 1.11.17 May 12, 2023
@michi-covalent michi-covalent added this to Needs backport from main in 1.11.19 Jun 14, 2023
@michi-covalent michi-covalent removed this from Needs backport from main in 1.11.18 Jun 14, 2023
@gentoo-root gentoo-root added this to Needs backport from main in 1.11.20 Jul 26, 2023
@gentoo-root gentoo-root removed this from Needs backport from main in 1.11.19 Jul 26, 2023
@nebril nebril added this to Needs backport from main in 1.11.21 Aug 10, 2023
@nebril nebril removed this from Needs backport from main in 1.11.20 Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@ungureanuvladvictor ungureanuvladvictor ungureanuvladvictor approved these changes

@sayboras sayboras sayboras approved these changes

@jibi jibi Awaiting requested review from jibi

Assignees
No one assigned
Labels
area/daemon Impacts operation of the Cilium daemon. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale.
Projects
No open projects
1.11.21
Needs backport from main
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@christarazi @sayboras @odinuge @joestringer @ungureanuvladvictor @aanm