Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: provide CI images with unstripped binaries #20238

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Jun 17, 2022

These will be tagged with :<SHA>-unstripped and :latest-unstripped and
are e.g. useful for profiling.

Fixes #20161

@tklauser tklauser added the release-note/ci This PR makes changes to the CI. label Jun 17, 2022
@tklauser tklauser force-pushed the pr/tklauser/ci-unstripped-images branch 3 times, most recently from a1a18ad to 59d310c Compare June 17, 2022 09:13
@tklauser tklauser marked this pull request as ready for review June 17, 2022 09:27
@tklauser tklauser requested review from a team as code owners June 17, 2022 09:27
@tklauser tklauser requested a review from pchaigno June 17, 2022 09:27
These will be tagged with :<SHA>-unstripped and :latest-unstripped and
are e.g. useful for profiling.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/tklauser/ci-unstripped-images branch from 59d310c to 0804dca Compare June 17, 2022 09:32
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aanm aanm merged commit 00b2a2f into master Jun 17, 2022
@aanm aanm deleted the pr/tklauser/ci-unstripped-images branch June 17, 2022 15:53
@tklauser tklauser added the area/CI-improvement Topic or proposal to improve the Continuous Integration workflow label Jun 17, 2022
@tklauser
Copy link
Member Author

I guess we might also want unstripped images for v1.11 and maybe also v1.10? Adding respective backport labels.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.7 Jun 17, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.13 Jun 17, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.7 Jun 28, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.13 Jun 28, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.13 Jul 5, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.13 Jul 5, 2022
@qmonnet qmonnet added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jul 6, 2022
@joestringer joestringer moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.7 Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.13
Backport done to v1.10
1.11.7
Backport done to v1.11
Development

Successfully merging this pull request may close these issues.

CFP: Ship binaries/container-images stripped/unstripped
7 participants